Lib Fixes: Copy and Paste Bugs - #4222
Open
MicahMaphet wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Bug fixes and linting for libs. The main bug was bitcore-lib-cash calling segwit functions causing errors. The others errors are sparse and documented in the Changelog.
Motivation
For #4194 I need to add utxos to a bitcore-lib-cash transaction using
associateInputs, but doing so throws an error because the inputs are checked for being a witness when BCH does not have SegWit. Ths PR removes those checks. I used Opus 5 to find similar errors copy and paste.Changelog 🗒️
isWitnessScriptHashOut/isWitnessPublicKeyHashOut) from transaction input classificationbitcore-libinstead ofbitcore-lib-cashSEQUENCE_LOCKTIME_DISABLE_FLAGreference (missingInterpreter.qualifier) in interpreterSCRIPT_VERIFY_CLEANSTACKflag definitionoutput.jsinternal branch tracking to use_branch/_isValidconsistently and fix validity checkbech32prefixassignment innetworks.jscryptovariable tonodeCryptoinhash.jsto stop shadowing the Node built-in globalbreakstatements,varredeclarations, andthis-aliasing in script interpretersTesting Notes 🥼
No significant functional changes so tests should catch everything
Checklist ✔️