Bluetooth Low Energy (BLE) Link Driver#442
Draft
UnexDev wants to merge 4 commits intobitcraze:masterfrom
Draft
Conversation
Author
|
Currently implementing threading to be able to create a new asyncio event loop. |
knmcguire
added
the
Triage needed
Contributor
|
Hi! and thanks! Sorry for the late reply but we will discuss this at our next triage meeting |
ataffanel
removed
the
Triage needed
Member
|
We still needs some time to properly review it. It won't be time for the immediate next release though. @UnexDev What is your current state on this PR? It seemed that it was still in progress. Do you want to commit anything else? |
Contributor
|
Hi @UnexDev ! I just want to check up on the status of this PR. If not we will need to close this PR for now, however it can be reopened if needed in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the CRTP over BLE. The implementation is not fully done yet, but I feel like opening this PR will allow for feedback and faster development.
The only thing that I don't know about is the fact that the only way to use the driver is to use the
asynciopackage along with it. This is, as far as I know, the only way to resolve acoroutine.