ci: check no_std and WASM builds, harden workflow - #86
Open
evanlinjin wants to merge 1 commit into
Open
evanlinjin wants to merge 1 commit into
evanlinjin wants to merge 1 commit into
Conversation
Add `Check no_std` and `Check WASM` jobs, modelled on bdk_wallet's CI.
The crate is `#![no_std]` with an optional `std` feature, but nothing
previously built it without default features.
Also set `permissions: {}` and `persist-credentials: false` on every
checkout so jobs don't hold a token they never use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage 1 of fixing the required status checks on
master.The
Default Branchruleset requires 14 checks copied from an older bdk_wallet CI (miniscript/no-std,bdk_chain/hashbrown, and so on). Nothing in this repo reports them, so every PR sits on "Expected — waiting for status" indefinitely.This PR ports the bdk_wallet jobs that make sense for this crate:
Check no_std:cargo check --no-default-features. The crate is#![no_std]with an optionalstdfeature, but CI never built it without default features.Check WASM:cargo check --target wasm32-unknown-unknown --no-default-features. The crate is pure Rust, so bdk_wallet's clang setup isn't needed.permissions: {}at the workflow level andpersist-credentials: falseon every checkout.Left out: the ARM runner matrix (little value for integer arithmetic), code coverage (needs a
CODECOV_TOKENsecret) and zizmor.Follow-up (needs a repo admin)
Replace the ruleset's required checks with the jobs this repo actually runs:
Rustfmt,clippy_check,build-msrv,test,doc-build,Check no_std,Check WASM.Checklists
cargo check --no-default-featuresand the WASM check pass locallycargo fmt,clippy,docandtestpass locally🤖 Generated with Claude Code