Draft
Conversation
Update dependencies: chain core bitcoind_rpc -> 0.22.0 electrum esplora file_store -> 0.22.0 Changes: Update usage of `LocalChain` and `CheckPoint` which are now generic. Change structure of `WalletTx` (alias for `CanonicalTx`). Introduce `Wallet::canonical_view`. Update `balance` with re-defined trust predicate. Fixup tests and documentation examples.
`build_fee_bump` and `finalize_psbt` now rely on the most recent view of canonical txs instead of re-canonicalizing on the fly.
This ensures that the wallet's canonical view is updated after inserting a txout. Currently *not all* `Wallet` methods that modify the transaction graph will update the `canonical_view`, though they arguably should, e.g. `apply_unconfirmed_txs`. Docs for `apply_update` are updated to include an Errors section and a note about the canonical view.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 85.24% 85.03% -0.22%
==========================================
Files 23 23
Lines 8230 8232 +2
==========================================
- Hits 7016 7000 -16
- Misses 1214 1232 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently in draft, the purpose of this PR is to test the wallet crate using the latest version of
bdk. This branch can be updated to depend on version0.24.0ofbdk_chainwhen that is released. Opening this now in response to a related comment bitcoindevkit/bdk#2083 (comment) regarding testing the new canonicalization APIs.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: