feat: public key generation from descriptors#355
Open
sdmg15 wants to merge 1 commit intobitcoindevkit:masterfrom
Open
feat: public key generation from descriptors#355sdmg15 wants to merge 1 commit intobitcoindevkit:masterfrom
sdmg15 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.01%
==========================================
Files 23 23
Lines 8230 8273 +43
==========================================
+ Hits 7016 7054 +38
- Misses 1214 1219 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdamuAbba
reviewed
Jan 16, 2026
| use crate::test_utils::insert_tx; | ||
|
|
||
| #[test] | ||
| fn test_generate_publick_keys() { |
There was a problem hiding this comment.
minor typo in function name k in public
Suggested change
| fn test_generate_publick_keys() { | |
| fn test_generate_public_keys() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR as a new function to the wallet API
public_key_at_index(keychain, index)which returns the public key found at the specified index. It closes #209Notes to the reviewers
I explicitly matched all arms branches of the
Descriptor<DefiniteDescriptorKey>so that if a new type is added in the future it signals there is a need to update this function too.Changelog notice
public_key_at_index(keychain, index)which returns the public key found at the specified index.Checklists
All Submissions:
just pbefore pushingNew Features: