fix(electrum): backport PR#2188#2228
Open
oleonardolima wants to merge 2 commits into
Open
Conversation
oleonardolima
requested review from
ValuedMammal,
evanlinjin,
luisschwab and
nymius
oleonardolima
added
the
backport
An Electrum server could return an arbitrary transaction when `fetch_tx()` requests a specific txid. The returned transaction was cached and used without verifying that its computed txid matches the requested one. Add a verification check that `tx.compute_txid() == txid` after fetching from the server, returning an error on mismatch. Signed-off-by: Elias Rohrer <dev@tnull.de>
oleonardolima
force-pushed
the
backport/pr-2188
branch
from
b58b9a9 to
f477553
Compare
1 task
nymius
approved these changes
Jun 16, 2026
sdmg15
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's a backport for the the
bdk_electrumfix introduced by #2188. If you're interested in the original fix, check the original PR for discussion/rationale.Changelog notice
Checklists
All Submissions: