Skip to content

ci: switch from coveralls to codecov for coverage reporting#2144

Open
shubham-shinde-442 wants to merge 1 commit intobitcoindevkit:masterfrom
shubham-shinde-442:ci/switch-to-codecov
Open

ci: switch from coveralls to codecov for coverage reporting#2144
shubham-shinde-442 wants to merge 1 commit intobitcoindevkit:masterfrom
shubham-shinde-442:ci/switch-to-codecov

Conversation

@shubham-shinde-442
Copy link

Closes: #2093

Description

Migrates code coverage reporting from Coveralls to Codecov.

  • Replaced coverage service: Switched from coverallsapp/github-action to codecov/codecov-action@v5.5.2 (pinned commit SHA for security)
  • Added permissions: Added contents: read and pull-requests: write to enable Codecov PR comments
  • Codecov configuration: Added flags: rust and name: codecov-bdk for better organization

Notes to the reviewers

Changelog notice

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.35%. Comparing base (8dd0209) to head (86287ae).
⚠️ Report is 1540 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2144      +/-   ##
==========================================
- Coverage   77.36%   77.35%   -0.02%     
==========================================
  Files          35       28       -7     
  Lines        9035     5466    -3569     
  Branches        0      237     +237     
==========================================
- Hits         6990     4228    -2762     
+ Misses       2045     1172     -873     
- Partials        0       66      +66     
Flag Coverage Δ
rust 77.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notmandatory notmandatory moved this to Needs Review in BDK Chain Mar 12, 2026
@notmandatory notmandatory added the chore Non-coding related work label Mar 12, 2026
@notmandatory notmandatory added this to the Chain 0.24.0 milestone Mar 12, 2026
flags: rust
name: codecov-bdk
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the pipeline fail if error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't think we need to fail, and we don't fail for the bdk_wallet crate either. But worth reconsidering if we begin to see a problem with new PRs not having adequate coverage.
https://github.com/bitcoindevkit/bdk_wallet/blob/fca652370c466c79659afc6ae57c5015d4007b18/.github/workflows/code_coverage.yml#L46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

[coverage] Switch to codecov/codecov-action

3 participants