ci: switch from coveralls to codecov for coverage reporting#2144
ci: switch from coveralls to codecov for coverage reporting#2144shubham-shinde-442 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
- Coverage 77.36% 77.35% -0.02%
==========================================
Files 35 28 -7
Lines 9035 5466 -3569
Branches 0 237 +237
==========================================
- Hits 6990 4228 -2762
+ Misses 2045 1172 -873
- Partials 0 66 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
notmandatory
left a comment
There was a problem hiding this comment.
ACK 86287ae
Confirmed using the same version of codecov GitHub action as bdk_wallet.
https://github.com/bitcoindevkit/bdk_wallet/blob/fca652370c466c79659afc6ae57c5015d4007b18/.github/workflows/code_coverage.yml#L40
| flags: rust | ||
| name: codecov-bdk | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| fail_ci_if_error: false |
There was a problem hiding this comment.
Good question, I don't think we need to fail, and we don't fail for the bdk_wallet crate either. But worth reconsidering if we begin to see a problem with new PRs not having adequate coverage.
https://github.com/bitcoindevkit/bdk_wallet/blob/fca652370c466c79659afc6ae57c5015d4007b18/.github/workflows/code_coverage.yml#L46
Closes: #2093
Description
Migrates code coverage reporting from Coveralls to Codecov.
coverallsapp/github-actiontocodecov/codecov-action@v5.5.2(pinned commit SHA for security)contents: readandpull-requests: writeto enable Codecov PR commentsflags: rustandname: codecov-bdkfor better organizationNotes to the reviewers
Changelog notice
All Submissions:
New Features:
Bugfixes: