Extract compute pubkey from compute script pubkey#46
Draft
setavenger wants to merge 1 commit intobitcoindevkit:masterfrom
Draft
Extract compute pubkey from compute script pubkey#46setavenger wants to merge 1 commit intobitcoindevkit:masterfrom
setavenger wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Split get_silentpayment_script_pubkey into two functions. Adds a distinct function to compute a silentpayment pubkey. Helps other implementations utilising this crate by exposing more low level functions.
Collaborator
|
Do you have any other use of this function than generate the pubkeys with both parities? I would prefer to not leave to the user the building of the script pubkey, as it may be a source of mistakes. Maybe reducing the return output of the old function to the two possible script pubkeys is better, although I'm not completely happy with that. Returning both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split get_silentpayment_script_pubkey into two functions. Adds a distinct function to compute a silentpayment pubkey. Helps other implementations utilising this crate by exposing more low level functions.
Checklists
All Submissions:
just p(fmt, clippy and test) before committing