BIP Draft: Standard Encrypted Wallet Payload#1981
Conversation
murchandamus
left a comment
There was a problem hiding this comment.
Hello @KeysSoze,
This document is incorrectly formatted in a manner that makes me think that it was AI generated. If you are still interested in pursuing this proposal, could you please fix the formatting?
At this time, given the lack of replies on the mailing list and comments on this PR, it is not clear to me that this proposal is being pursued for implementation by any Bitcoin project. Given that there are several other backup related proposals in flight, perhaps some of the corresponding authors would be interested in reviewing your document if you review theirs.
I‘d be happy to provide a more thorough review when this proposal has gotten review from other parties and that review has been addressed, or the proposal otherwise distinguishes itself from its perceived AI-generated origin.
|
Hello @KeysSoze, I was referring to the unnecessary HTML tags in the document. If you are still working on this, there are some similar proposals that have been recently merged or are still in flight
which might interest you. |
Changed preamble to more closely follow BIP standards Removed table of contents
|
Hi @murchandamus,
Yes, it seems BIP139: Wallet Metadata Backup Format is quite similar to this proposal. But rather than using JSON, this proposal defines a rigid CDDL schema with deterministic CBOR, enforcing true inter-wallet compatibility. CBOR's compact binary nature drastically reduces the payload size making air-gapped QR codes or NFC transfers highly viable if defined in a companion BIP. Furthermore, the modular nature of this proposal delegates security to battle-tested IETF standards like COSE via a separate companion BIP. This ensures the standard is inherently future-proofed. As cryptography advances developers can seamlessly upgrade ciphers, implement multi-party authorisation or adopt post-quantum algorithms within the security container without ever needing to alter the core wallet payload format. |
murchandamus
left a comment
There was a problem hiding this comment.
I gave this a first read. Has any Bitcoin project adopted this scheme or is working on adopting it? Please add the required Backwards Compatibility section.
|
cc: @pythcoiner, I thought you might be interested in this. |
|
Hi @murchandamus, Thanks again for reviewing this. To date, no Bitcoin project has implemented this scheme. Because BIP-138 and BIP-139 overlap significantly with large portions of this proposal, we have intentionally slowed our updates while we observe how those developments unfold. However, in our completely biased opinion, this proposal offers distinct advantages over alternative approaches. As mentioned above, utilising the IETF standard CBOR yields a format substantially more compact than JSON. Furthermore, its modular design allows us to leverage existing IETF specifications (such as COSE for encryption), ensuring we don't reinvent the wheel while keeping the framework highly future-proof |
|
You’re welcome, @KeysSoze. It seems distinct enough to me, that both could move forward. Although it would of course be better if the ecosystem settled on one standard, that is not usually how these things play out. |
|
Hey @KeysSoze, this still has unaddressed review. Please process the review comments and mark them as resolved as you get through them. |
Changed the type from 'Standards Track' to 'Specification'.
Updated the description of the 'accounts' field to clarify that it contains one or more descriptors.
Updated descriptions for testnet and signet entries to clarify their nature.
Add 'Required' column to the wallet key description table.
This pull request proposes a new BIP for a standard, interoperable format for encrypted wallet backups and transfers.
The core design choice is the separation of the data
payloadfrom the cryptographiccontainer. This BIP specifies thepayloadformat, while mandating that it must be encrypted by a container defined in companion proposals.Key features include:
This proposal was previously posted to the Bitcoin-Dev mailing list: https://groups.google.com/g/bitcoindev/c/3I-qtBhzIGY
Seeking assignment of a BIP number and welcoming all feedback.