Remove -Werror on the robot - #1033
Merged
Merged
Conversation
jgueldenstein
approved these changes
Aug 18, 2026
Member
|
I think we should remove the warning as error from the default build as well as it potentially causes more pain than it has benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The zed_components package on the robot produces a lot of warnings, some of them not in the files we are vendoring.
Proposed changes
This PR disables -Werror on the robot, keeping it active for the CI and PC builds. Those don't build zed_components so they work correctly
Related issues
See #1027. I would suggest to not close that issue incase we ever want to tackle these warnings (some of them are absolutely relevant)
Checklist
pixi run buildWrite documentation