get to 100% code coverage - #3945
Open
MichaelWest22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Went though the code loc coverage report and added tests for each missing line of coverage. None of the remaining untested code was of any real concern and no actual bugs or issues needed resolving. But getting to 100% lets you see the future untested code lines much easier.
The only issue I had is testing window.location usage for refresh etc. These tests break the test suite making them untestable. So to get to 100% i had to add the window.location mocking point via htmx.__location. We only need this for our internal test mocking and we don't have to ship this exposed so I added sed commands to minimize and strip the additions from the shiped htmx.js in dist when built.
Corresponding issue:
Testing
Just added loads of new tests for all the edge cases
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded