Conversation
Telroshan
added
bug
Collaborator
<input type="checkbox"> is special in that it shows up with a value of "on", even if it is not checked. Introduce a helper function for getting the effective value of a node by handling this pecularity.
jsonn
force-pushed
the
changed-checkbox
branch
from
November 15, 2025 16:47
8571b9e to
1f24c6c
Compare
Contributor
Author
|
Rebased on current dev, should be easy to merge now. |
4 tasks
Contributor
|
thank you for this contribution, sorry it sat so long, looks like this affects 4.x too so I'm talking w/ @MichaelWest22 about best fixes |
Collaborator
|
Fixed in my 4 PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unlike other form elements, checkbox elements will return
onwhether or not they are currently ticked. Explicitly handle this by checking for the tag name and type and then use the checked property.Testing
A new test case is included, failing before.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeededNote: this PR is on top of #2893