Skip to content

fix hdb console form parse error caused by duplicate end#665

Open
andreahlert wants to merge 1 commit intobigskysoftware:masterfrom
andreahlert:fix/hdb-console-form-parse-error
Open

fix hdb console form parse error caused by duplicate end#665
andreahlert wants to merge 1 commit intobigskysoftware:masterfrom
andreahlert:fix/hdb-console-form-parse-error

Conversation

@andreahlert
Copy link
Copy Markdown

Fixes #539

The #console-form hyperscript had a duplicate end that caused the parser to exit the on keydown handler early. The next set command got parsed as a feature-level declaration, which requires element-scoped variables, so it threw "variables declared at the feature level must be element scoped".

One end removed, debugger works again.

Tested locally with both inline breakpoint (on click breakpoint) and function breakpoint (def with breakpoint inside). HDB opens, expression eval works, no console errors.

Fixes bigskysoftware#539

Signed-off-by: André Ahlert <andre@aex.partners>
@andreahlert
Copy link
Copy Markdown
Author

netlify deploy preview is failing but looks like it's broken on all open PRs, not just this one. the change is just one end removed so shouldn't be related

@1cg when you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hyperscript debugger UI form error on being element scoped in set Feature #hdb #breakpoint #set #feature

1 participant