fix hdb console form parse error caused by duplicate end#665
Open
andreahlert wants to merge 1 commit intobigskysoftware:masterfrom
Open
fix hdb console form parse error caused by duplicate end#665andreahlert wants to merge 1 commit intobigskysoftware:masterfrom
andreahlert wants to merge 1 commit intobigskysoftware:masterfrom
Conversation
Fixes bigskysoftware#539 Signed-off-by: André Ahlert <andre@aex.partners>
Author
|
netlify deploy preview is failing but looks like it's broken on all open PRs, not just this one. the change is just one @1cg when you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #539
The
#console-formhyperscript had a duplicateendthat caused the parser to exit theon keydownhandler early. The nextsetcommand got parsed as a feature-level declaration, which requires element-scoped variables, so it threw "variables declared at the feature level must be element scoped".One
endremoved, debugger works again.Tested locally with both inline breakpoint (
on click breakpoint) and function breakpoint (defwithbreakpointinside). HDB opens, expression eval works, no console errors.