fix(core): update gift certificate amount handler to include amount_display#2901
Merged
jordanarldt merged 1 commit intocanaryfrom Feb 25, 2026
Merged
fix(core): update gift certificate amount handler to include amount_display#2901jordanarldt merged 1 commit intocanaryfrom
jordanarldt merged 1 commit intocanaryfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 495e827 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jordanarldt
force-pushed
the
fix/gift-cert-purchase
branch
from
1a26671 to
32b1ede
Compare
chanceaclark
approved these changes
Feb 25, 2026
jorgemoya
approved these changes
Feb 25, 2026
jordanarldt
force-pushed
the
fix/gift-cert-purchase
branch
from
32b1ede to
c4d8f75
Compare
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
…amount_display The form change handler only checked for inputs named 'amount', but the select element for predefined gift certificate amounts uses the name 'amount_display'. This caused the GiftCertificateCard preview to not update when selecting a new amount from the dropdown.
jordanarldt
force-pushed
the
fix/gift-cert-purchase
branch
from
c4d8f75 to
495e827
Compare
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The
GiftCertificateCardpreview component was not updating when selecting a predefined amount from the dropdown on the gift certificate purchase form.The
handleFormChangehandler only checked for inputs withname === 'amount', but the select element for predefined gift certificate amounts uses the nameamount_display. This meant selecting a new amount from the dropdown was silently ignored, and the card preview never reflected the selected value.The fix adds
amount_displayto the name check so both the custom amount input and the predefined amount select trigger the card preview update.Rollout/Rollback
No special rollout needed. Simple code change with no migrations or feature flags. Rollback is a standard revert.
Testing
GiftCertificateCardpreview updates to show the formatted amountBefore fix
After fix