Skip to content

Fix terminal uploads, note persistence feedback, and GUI regressions - #212

Open
bifrost0x wants to merge 2 commits into
mainfrom
codex/fix-upload-notes-and-gui
Open

Fix terminal uploads, note persistence feedback, and GUI regressions#212
bifrost0x wants to merge 2 commits into
mainfrom
codex/fix-upload-notes-and-gui

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Changes

Fix the terminal drop flow so files are queued only after confirming the destination. A single handler receives the real session manager, captures the active target at drop time, and keeps that target if the user switches sessions. The dialog shows the server and destination folder; relative paths explicitly refer to the SFTP home directory. Disconnected targets fail instead of falling back to another session.

  • Read every directory-entry batch and await the matching directory-creation response before uploading children. Stop on creation failure, disconnect, or timeout.
  • Show notes as saved only after a successful server acknowledgement. Preserve dirty text across reconnects and late responses, serialize pending saves, report failures/offline state, enforce the character limit, and warn before leaving with unsaved notes.
  • Accept IPv6 and IDN hosts in Quick Connect hints, align dotted usernames with the existing backend policy, and localize validation/status text in all six locales.
  • Constrain the settings navigation grid and wrap translated labels so the German sidebar no longer overlaps content at intermediate widths.

Validation

  • 2,826 Python tests passed across the full suite and a separate socket-capacity run; 29 skipped. The capacity test required local socket permissions unavailable in the initial sandbox run.
  • All 43 JavaScript test files passed; ESLint and git diff --check passed.
  • 22 browser tests passed, covering the new regressions and existing Quick Connect, File Manager, and account-menu flows.
  • Directory tests cover 200 entries across multiple batches, response correlation, failure cleanup, cancellation, and target binding. Browser tests verify real note persistence/reconnect and sidebar bounds at 601, 768, 900, and 1024 pixels.

Browser checks used the isolated E2E instance. SSH targets and transfers in the drop regression were simulated; no external SSH/SFTP/SMB server was contacted.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T15:37:03.927152Z 27db588 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27db588dd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/notepad-controller.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant