fix: surface signal failures and reject non-UTF-8 env files#12
Merged
Conversation
Signal errors were silently swallowed and printed to stderr, returning a partial Discovery with no indication of failure. Now collected into Discovery.warnings (omitted from JSON when empty) so callers and CLI consumers can detect incomplete results. Also replaces from_utf8_lossy with from_utf8 when parsing docker-compose env_file references — non-UTF-8 content is now skipped rather than having bytes silently replaced with U+FFFD, which could corrupt env key parsing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal errors were silently swallowed and printed to stderr, returning a partial Discovery with no indication of failure. Now collected into Discovery.warnings (omitted from JSON when empty) so callers and CLI consumers can detect incomplete results.
Also replaces from_utf8_lossy with from_utf8 when parsing docker-compose env_file references — non-UTF-8 content is now skipped rather than having bytes silently replaced with U+FFFD, which could corrupt env key parsing.