ci: corregir workflows rotos (shell vendorizado inexistente + npm en dir equivocado) - #7
Merged
Merged
Conversation
Dos bugs de configuración que dejaban la CI en rojo por rutas/entorno, no por el código: - build.yml (.NET Build & Test): elimina los pasos que restauran/compilan soluciones de shell VENDORIZADAS inexistentes (src/libs/shell/ddd/.../Ums.Shell.Ddd.sln, Ums.Shell.Factory.sln → MSB1009 "Project file does not exist"). Los shells cross son paquetes NuGet BeyondNetCode.Shell.* publicados en nuget.org (v1.0.0) y los resuelve el restore de Ums.sln vía PackageReference. - ci.yml (UMS Monorepo CI): el job corría en la raíz del repo, pero el workspace npm/nx vive en src/ (npm ci → ENOENT package.json). Se fija defaults.run.working-directory: src, se sube Node 18 → 22 (React Router v8 exige node>=22) y se apunta el cache de npm a src/package-lock.json. No se tocan las puertas de calidad (lint/test/audit): siguen ejerciendo su función; el rojo restante que puedan mostrar es deuda preexistente del repo (seeding de integración G-014, deuda de lint global, vulnerabilidades), no un defecto de estos workflows. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Corrige dos bugs de configuración de CI que dejaban
mainen rojo por rutas/entorno, no por el código.build.yml— .NET Build & TestEliminaba los pasos que restauran/compilan/testean soluciones de shell vendorizadas inexistentes:
src/libs/shell/ddd/src/Ums.Shell.Ddd/Ums.Shell.Ddd.slnsrc/libs/shell/factory/src/Ums.Shell.Factory.sln→
MSBUILD error MSB1009: Project file does not exist. Los shells cross son paquetes NuGetBeyondNetCode.Shell.*(públicos en nuget.org, v1.0.0; reposbeyondnetcode/Shell.*), que resuelve elRestore – UMS APIvíaPackageReference.ci.yml— UMS Monorepo CIEl job corría en la raíz del repo, pero el workspace npm/nx vive en
src/→npm cifallaba conENOENT package.json. Correcciones:defaults.run.working-directory: srccache-dependency-path: src/package-lock.jsonNota
No se tocan las puertas de calidad (lint/test/audit). El rojo que puedan seguir mostrando es deuda preexistente del repo (seeding de integración G-014, deuda de lint global, vulnerabilidades), no un defecto de estos workflows.
🤖 Generated with Claude Code