release: promocionar develop a main (048478d5) - #712
Merged
Merged
Conversation
…E ES enlaza la captura ES Dos hallazgos de revisión sobre la promoción #710, ambos reales: 1. `sdk-cli-release.yml` / `publish-npm`: tras #708 un tag `cli-vX.Y.Z` llega a `npm publish` sin haber compilado `src/rulesets/opa/policy.wasm` (gitignored; el build raíz es `tsc -b`). `prepublishOnly` copia rulesets y termina en `check:install-smoke`, que exige un wasm no trivial — existe porque 1.2.2 se publicó con 87 `.rego` y cero wasm. La primera release real del CLI moría en el último paso con todos los gates en verde. Se añade el mismo paso que ya tiene `npm-release.yml`: `npm run build:policy` + `test -f`. 2. `README.es.md`: la nota bajo la demo enlazaba `first-run-capture.md` en vez de `first-run-capture.es.md`, que existe. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
El guard bilingüe vio README.es.md moverse sin README.md en 02833d7 y bloqueó `Validate documentation`, que es lo que existe para hacer. La edición es genuinamente unilateral: el enlace ES apuntaba a la captura EN y la mitad EN ya apuntaba a la suya, así que no hay contraparte que mover. Va a ALLOWED con su razón, como pide el propio guard para este caso. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…m-and-es-evidence-link fix(release): compilar policy.wasm antes de publicar el CLI; README ES enlaza la captura ES
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 048478d509
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promoción
develop→main, fijada a048478d5para que lo que se revisa sea lo que se mergea. Sigue a #710; sube exactamente un PR, el que cierra los dos hallazgos de revisión de aquella.Qué sube
Release del CLI y portada ES — #711
sdk-cli-release.yml/publish-npm: compilapolicy.wasmantes denpm publish(el mismo paso quenpm-release.yml). Sin él, el primer tagcli-v*moría encheck:install-smokecon todos los gates verdes.README.es.md: la nota bajo la demo enlazafirst-run-capture.es.md; la edición ES-only queda declarada en el guard 66 con su razón.🤖 Generated with Claude Code