fix(release): normalise bin paths so npm stops auto-correcting on publish - #227
Merged
Merged
Conversation
…lish The second dry run (30271837941) was clean on everything the first one found — LICENSE ships in all four packages, repository.url no longer normalised — but still reported two auto-correction warnings, from a different cause: npm warn publish "bin[evolith-mcp]" script name was cleaned npm warn publish "bin[evolith]" script name was cleaned npm warn publish "bin[evolith-cli]" script name was cleaned `mcp-server` and `cli` declared their bins as `./dist/main.js`; npm strips the leading `./` on publish and warns while doing it. Declaring the normalised form is what `npm pkg fix` would do, and it changes nothing about how the binaries resolve — verified after the change: `cli --version` prints 1.2.0 and the MCP server still starts. Publishing through a warning means accepting that npm rewrites your manifest for you. With the warnings at zero, what is declared is what is published. Both defects fixed in this release preparation were found by rehearsal, and both would have been permanent — npm forbids unpublishing after 72 hours. That is the argument for `dry_run` defaulting to true, restated as evidence rather than opinion. Verified: 10-validate-contract-conformance, 11-validate-product-docs and 24-check-surface-parity exit 0; ci-runner governance 17/17 exit 0; `npm pack --dry-run` reports 0 auto-correction warnings for both packages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Last defect found by rehearsal before publishing 1.2.0.
The second dry run (30271837941) was clean on everything the first one found — LICENSE ships in all four packages,
repository.urlno longer normalised — but still reported two auto-correction warnings from a different cause:mcp-serverandclideclared their bins as./dist/main.js; npm strips the leading./on publish and warns while doing it. Declaring the normalised form is whatnpm pkg fixwould do and changes nothing about resolution — verified after the change:cli --versionprints1.2.0and the MCP server still starts.Publishing through a warning means accepting that npm rewrites your manifest for you. With warnings at zero, what is declared is what is published.
Both defects fixed during this release preparation were found by rehearsal, and both would have been permanent — npm forbids unpublishing after 72 hours. That is the argument for
dry_rundefaulting to true, stated as evidence rather than opinion:repository.urlauto-corrected in all 8binpaths auto-corrected in 2Evolith Core Quality Gates
01-validate-docs.mjsgreen (viaci-runner governance).04-check-bilingual-parity.mjsgreen (viaci-runner governance).Verification
10-validate-contract-conformance,11-validate-product-docsand24-check-surface-parityexit 0 ·ci-runner governance17/17 exit 0 ·npm pack --dry-runreports 0 auto-correction warnings for both packages · binaries still resolve (cli --version→ 1.2.0, MCP server starts).Linked ADRs / Issues
Conventional Commits
🤖 Generated with Claude Code