docs(gaps): register GT-623 — unenforced commit convention drives release versioning - #221
Merged
Merged
Conversation
…forced, and drives versioning Observed live while merging `develop` into a working branch: `.husky/commit-msg` printed "commitlint is not installed — skipping commit message lint" and exited zero. Verified rather than assumed. The hook runs `npx --no -- commitlint --version` and, when that fails, prints the message and succeeds. `commitlint` is in neither `dependencies` nor `devDependencies` of the root package.json; there is no `commitlint.config.*`, no `.commitlintrc*`, and no `commitlint` key. The else branch is the only branch that ever runs. What depends on the convention it does not enforce: CONTRIBUTING.md and the PR template mandate Conventional Commits in three places, and release-please derives version bumps from commit messages in `sdk-cli-release.yml` and `sdk-cli-ci.yml`. It is already drifting, with a consequence worth naming: 2 of the last 60 non-merge commits use the type `security(...)`, which is not a Conventional Commits type. release-please does not recognise it, so a commit announcing itself as a security change contributes nothing to the version bump — the same failure mode as GT-570, where a security wave sits unpublished. Broken out of GT-574's process picture into its own row because the consequence is concrete and measurable, not atmospheric. Filed as P2/S: failing open is worse than having no hook, because it manufactures the appearance of enforcement. Board: 561/623 done, 9 in progress, 49 pending, 4 deferred. Verified: 08-validate-tracking 623 gaps (ES 623), 599/599 EN/ES catalog sections, 543 closure records; ci-runner governance 17/17 exit 0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Registers GT-623: the commit convention is mandated in three places, enforced by nothing, and release versions are derived from it.
Observed live, not inferred —
.husky/commit-msgprintedcommitlint is not installed — skipping commit message lintand exited zero while mergingdevelopinto this branch. It did it again on the commit that registers the gap.Verified rather than assumed. The hook runs
npx --no -- commitlint --versionand, when that fails, prints the message and succeeds.commitlintis in neitherdependenciesnordevDependenciesof the rootpackage.json; there is nocommitlint.config.*, no.commitlintrc*, and nocommitlintkey. The else branch is the only branch that ever runs.What depends on the convention it does not enforce.
CONTRIBUTING.mdand.github/pull_request_template.mdmandate Conventional Commits in three places, and release-please derives version bumps from commit messages insdk-cli-release.ymlandsdk-cli-ci.yml.It is already drifting, with a consequence. 2 of the last 60 non-merge commits use the type
security(...), which is not a Conventional Commits type. release-please does not recognise it, so a commit announcing itself as a security change contributes nothing to the version bump — the same failure mode as GT-570, where a security wave sits unpublished. Two symptoms of one mechanism.Broken out of GT-574's process picture into its own row because the consequence is concrete and measurable. The acceptance criteria keep all three options open on purpose: installing commitlint is not automatically the right one — failing open is worse than having no hook, because it manufactures the appearance of enforcement.
Board: 561/623 done · 9 in progress · 49 pending · 4 deferred.
Evolith Core Quality Gates
.mdand.es.mdfrom a single data structure, so the pair cannot drift.01-validate-docs.mjsgreen (viaci-runner governance).04-check-bilingual-parity.mjsgreen (viaci-runner governance).Verification
08-validate-tracking623 gaps (ES 623), 599/599 EN/ES catalog sections, 543 closure records ·ci-runner.mjs governance17/17 exit 0.Linked ADRs / Issues
Conventional Commits
🤖 Generated with Claude Code