Skip to content

Fixes as recommended by codacy.#101

Draft
besser82 wants to merge 1 commit intodevelopfrom
besser82/codacy_fixes
Draft

Fixes as recommended by codacy.#101
besser82 wants to merge 1 commit intodevelopfrom
besser82/codacy_fixes

Conversation

@besser82
Copy link
Copy Markdown
Owner

This is WIP. Do not merge, yet.

@besser82 besser82 force-pushed the besser82/codacy_fixes branch from b8c5305 to c01c717 Compare February 25, 2020 14:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.34%. Comparing base (d2b3f02) to head (836a732).
⚠️ Report is 313 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    94.27%   94.34%   +0.06%     
===========================================
  Files           32       32              
  Lines         3688     3765      +77     
===========================================
+ Hits          3477     3552      +75     
- Misses         211      213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@besser82 besser82 force-pushed the besser82/codacy_fixes branch from c01c717 to 836a732 Compare February 25, 2020 14:13
@besser82
Copy link
Copy Markdown
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@zackw
Copy link
Copy Markdown
Collaborator

zackw commented Oct 12, 2020

Some Markdown processors attach semantic significance to whether or not there are blank lines between elements of a bullet list. (For instance, they render to HTML as <ul><li><p>...</p></li><li><p>...</p></li>...</ul> with blank lines and <ul><li>...</li><li>...</li>...</ul> without.) It doesn't especially matter for TODO.md but I'm concerned that Codacy is applying blanket style rules without taking this into account.

Also, a change that touches only TODO.md shouldn't have any effect on code coverage, do you have any idea why that happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants