Skip to content

build: pin PIT in the root POM; TODO.md after the green main run - #265

Merged
bernardladenthin merged 1 commit into
mainfrom
docs/todo-main-green
Nov 2, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
docs/todo-main-green

Conversation

@bernardladenthin

@bernardladenthin bernardladenthin commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner
  • PIT from the root works offline. The root POM is part of the reactor, so
    mvn test-compile org.pitest:pitest-maven:mutationCoverage (the documented command, what CI runs)
    asked the remote metadata for a plugin version and failed offline. pitest-maven 1.30.1, the
    version the modules already pin, is now in the root's pluginManagement. Checked offline:
    -pl .,srcmorph-maven-plugin runs, 80/80 killed.
  • CLAUDE.md: the plugin module has 80 mutations, not 62.
  • TODO.md: the Publish run of main at d962383 (merge of chore: main to 1.5.0-SNAPSHOT after the 1.4.0 release #264) is green, so the item about the
    cancelled main runs goes; the PIT item is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DuAkLtHrCTx81vP5Mt4jad

Summary by CodeRabbit

  • Documentation
    • Updated the documented mutation count for the Maven plugin from 62 to 80; the CLI count remains 24.
  • Chores
    • Pinned the PIT Maven plugin version in the parent build configuration, enabling consistent plugin resolution from the project root.

- The root POM is part of the reactor, so the documented
  `mvn test-compile org.pitest:pitest-maven:mutationCoverage` asked the
  remote metadata for a version of the prefix-less plugin and failed
  offline. pitest-maven 1.30.1, the version the modules pin, is now in the
  root's pluginManagement; offline the root and the plugin module run
  (80/80 killed).
- CLAUDE.md: the plugin module has 80 mutations, not 62.
- TODO.md: the Publish run of main at d962383 (merge of #264) is green, and
  the PIT item is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DuAkLtHrCTx81vP5Mt4jad
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1a0f35b4-5489-46c9-b12a-91447fffde44
Commits

Reviewing files that changed from the base of the PR and between d962383 and d73a26a.

Files selected for processing: 3
  • CLAUDE.md
  • TODO.md
  • pom.xml
Files with no reviewable changes: 1
  • TODO.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The parent POM pins pitest-maven to version 1.30.1. The TODO list removes two items, and CLAUDE.md updates the documented srcmorph-maven-plugin mutation count from 62 to 80.

Changes: PIT setup and documentation

Layer / File(s) Summary
PIT configuration and documentation
pom.xml, TODO.md, CLAUDE.md
The parent POM pins pitest-maven to version 1.30.1. The TODO list removes the PIT pin item and notes about cancelled Publish runs. CLAUDE.md updates the documented srcmorph-maven-plugin mutation count from 62 to 80.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: dependencies, java

Suggested reviewers: claude

Merge Risk: Minimal · up to d73a2

The change is mergeable; the PIT pin is correctly inherited, while the documentation count may be confirmed during normal validation.

Architecture risk: Low · up to d73a2

The change affects 3 systems.

Changed systems: CLAUDE.md, pom.xml, TODO.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CLAUDE.md (service) was modified; 1 changed file maps to changed impact.
  • observed — pom.xml (service) was modified; 1 changed file maps to changed impact.
  • observed — TODO.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CLAUDE.md: The documented srcmorph-maven-plugin PIT count changes from 62 to 80; the srcmorph-cli count remains 24.
  • observed — Modified behavior in CLAUDE.md: The documented srcmorph-maven-plugin mutation count changes from 62 to 80; the srcmorph and CLI counts are unchanged.
  • observed — Modified behavior in TODO.md: Removed the TODOs about the cancelled Publish runs for 530c55c and b4930a3 and the root PIT plugin pin needed for the documented offline command.
  • observed — Modified behavior in pom.xml: Adds a pitest-maven plugin-management entry pinned to version 1.30.1.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two changes: pinning PIT in the root POM and updating TODO.md after the green main run. The changeset pins pitest-maven 1.30.1 in the root pom.xml pluginManagement, which is the main c…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two changes: pinning PIT in the root POM and updating TODO.md after the green main run. The changeset pins pitest-maven 1.30.1 in the root pom.xml pluginManagement, which is the main code change, so the title relates to a real and central part of the PR. It omits the CLAUDE.md mutation-count correction and the removal of TODO items, which is expected for a short title. The title is clear and specific, and it does not describe anything absent from the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

OSV Scanner (2.7.0)
pom.xml

OSV Scanner exited with code 128 without a usable report

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@bernardladenthin
bernardladenthin merged commit 3a47a7f into main Nov 2, 2026
32 of 34 checks passed
@bernardladenthin
bernardladenthin deleted the docs/todo-main-green branch November 2, 2026 22:06

This branch was successfully deployed

1 active deployment
startgate — d73a26ad Deployed Nov 2, 2026 by bernardladenthin via Start gate (abort window) #559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant