docs: clarify ai.* vs srcmorph.* property namespaces - #168
Merged
Conversation
…oc-consistency audit) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WUx9TF8QGQf6efgG5TkHi
…arameters Prevents future audits from mistaking the -Dai.* flags (ai.model, ai.gpuLayers, ai.mainGpu, ai.devices, ai.index.output.directory) for stale/invalid properties. They ARE valid: repo-local Maven <properties> in srcmorph-maven-plugin/pom.xml, wired into this module's own gpt-oss self-test/benchmark executions and overridable with -Dai.*. Downstream consumers of the published plugin set the same knobs as <configuration>/model-definition elements; the published mojo parameters are the separate srcmorph.* set. - pom.xml: header comment above the ai.* property block. - README.md: note before the -Dai.* usage in "Recommended Models". - CLAUDE.md: bullet documenting the two property namespaces. Comment/doc-only; no build behavior or parameters changed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WUx9TF8QGQf6efgG5TkHi
The "GPU acceleration (opt-in)" section targets downstream users of the published plugin, but its tuning bullets described the knobs via -Dai.gpuLayers /-Dai.mainGpu/-Dai.devices — which are this repo's own Maven build properties and do NOT exist in a downstream build. Reframed the two bullets to set <gpuLayers>/<mainGpu>/<devices> inside the user's <aiDefinition> (the real, documented config elements, cross-referenced to "Per-model <aiDefinition> parameters"), and kept -Dai.* only as an explicit "this repo's own presets" parenthetical. Consistent with the ai.* clarification note added earlier. Doc-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WUx9TF8QGQf6efgG5TkHi
bernardladenthin
had a problem deploying
to
maven-central
July 31, 2026 22:33 — with 
GitHub Actions
Failure
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
startgate
July 31, 2026 22:33 — with
GitHub Actions
Error
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
July 31, 2026 22:33 — with
GitHub Actions
Failure
GitHub Actions
Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai.*build properties (repo-local Maven configuration for self-test/benchmark executions) andsrcmorph.*mojo parameters (published plugin configuration).srcmorph.generationProviderinstead of-Dai.gpuLayersin command-line examples, with cross-references explaining the difference.Motivation
The repository has two distinct property namespaces that serve different purposes:
ai.*properties: Maven build properties defined insrcmorph-maven-plugin/pom.xml, used only for this repo's own gpt-oss profile executions (self-test, benchmarking). Overridable with-Dai.<name>=<value>at build time.srcmorph.*properties: Published mojo@Parameterannotations that downstream consumers use in their own<configuration>blocks.This distinction has previously tripped audits and code reviews. The changes make it explicit in multiple places (README, CLAUDE.md, pom.xml comments) so maintainers and contributors understand why
-Dai.gpuLayers=12is correct (not a bug to "fix" tosrcmorph.gpuLayers).Test plan
Related issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)https://claude.ai/code/session_018WUx9TF8QGQf6efgG5TkHi