Repository navigation
Upgrade llama.cpp from b11476 to b11512 (7 steps); ModelParameters.setMoeCacheMib - #486
Merged
Merged
Conversation
The reactor is at 5.2.0-SNAPSHOT (last release v5.1.0), so the first release with the Linux CPU-variant builds is 5.2.0; CLAUDE.md and TODO.md named 5.3.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
#29876 hands the chat parser the generated tokens next to the text: common_chat_input replaces the std::string of common_chat_parse(), of common_chat_parser_params::generation_prompt and of the server result types' content. Its string constructor is explicit, so the C++ tests wrap their literals; the wire format is unchanged. #29887 adds a GPU cache for the MoE experts a --cpu-moe setup keeps in host memory (--moe-cache-mib, EXPERIMENTAL). Exposed as ModelParameters.setMoeCacheMib(int) with ModelOption.MOE_CACHE_MIB, negative values rejected like upstream's parser does. All ten patches apply unchanged (verified in order against the pristine tag and by a fresh configure); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
All ten patches apply unchanged (verified in order against the pristine tag); see docs/history/llama-cpp-breaking-changes.md for the range. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
bernardladenthin
had a problem deploying
to
maven-central
October 8, 2026 19:20 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 8, 2026 19:20 — with
GitHub Actions
Failure
|
✅ Overall Assessment: This PR is well-structured and thoroughly tested. No quality, correctness, or security issues found. Strengths:
Code Quality:
Test Plan: All items verified
Security: No issues found - no new JNI entry points, proper input validation at boundary. |
|
9 of 10 tasks
bernardladenthin
pushed a commit
that referenced
this pull request
Oct 11, 2026
Appended section only, nothing above moved: the session that shipped the modular natives (#504 to #506) and watched their two full runs leaves its open items here for the branch that carries on. First item first: main (#506) and this branch each carry a 0018 patch for the same AMX line under different file names; after a merge the second one fails to apply and every native build goes red, while git merges the two patch files, the two CLAUDE.md rows and the two CHANGELOG bullets silently (only TODO.md conflicts). The item says what to keep. Then what was raised in the session and recorded nowhere: WER minidumps and the emulator pre-install are switched on but unproven; everything behind `package` has never run on the modular natives; the 8080/9931 server-port split; unpinned Maven plugins and `requirePluginVersions`; SECURITY.md/CONTRIBUTING.md never compared across the four repos; the unread SonarCloud finding on #486; the local-agent assignment that exists only in the session (with the OpenCL-ICD question item 1 lacks); the REUSE attribution of the dockcross wrappers; and the srcmorph smoke decision that lives in srcmorph's own TODO. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
0001override, the unconditional0002assignment, nosplit_sumguard for0012, nocommon_loghook for0014, nostop_serverfor0015, nokolibriundersrc/for0016). Upstream touched nothing under.github/in the range: CCCLv3.4.3, OpenVINO 2026.4.1 and ROCm 10.0.0 stay as they are.common_chat_inputreplaces thestd::stringofcommon_chat_parse(), ofcommon_chat_parser_params::generation_promptand of the server result types'content. Its string constructor isexplicit, sotest_server.cppandtest_utils.cppwrap their literals. Nothing moves on the wire -- request fields, their bounds and the response keys are identical between b11476 and b11512 (the two greps from the runbook), andjllama.cppreads results throughto_json()only.ModelParameters.setMoeCacheMib(int)(--moe-cache-mib, #29887 at b11480, split across GPUs by #30112 at b11512; EXPERIMENTAL upstream): a device-side cache for the MoE expert weights asetCpuMoeLayers/--cpu-moesetup keeps in host memory. Registered asModelOption.MOE_CACHE_MIB, sotest_model_flags.cppholds it against the server parser; negative values are rejected like upstream's parser does. Three tests inModelParametersTest, a CHANGELOG Added entry.SystemOneIntegrationTestcovers the endpoint, the models are not in the CI set), the reranker classifier activation as a model property (#29692, read from the GGUF), the context checkpoints kept across a slot save/restore (#26004 -- an appendix older state files simply lack, so they still restore), cpp-httplib 0.60.1 (b11505), and the Vulkan / CUDA / SYCL backend fixes.5.2.0-SNAPSHOT).Per-step record: two rows per range in
docs/history/llama-cpp-breaking-changes.md.Test plan
llama/patches/apply in order on each of the seven pristine tags (git apply), and at b11480 and b11512 a freshcmake -B … -DBUILD_TESTING=ONconfigure through the real FetchContent path succeeds (stamp lists the patches, heada11f57ba= b11512).ctest: 598/598 pass at both.LlamaLoaderTest,BackendLoadTest,NativeLibraryLoadSmokeTest(pinsLLAMA_CPP_VERSIONagainst the linked build),ModelParametersTest,WireNameRegistryTest,RpcServerTest,LlamaLoggerTest-- 167 tests, 0 failures.spotbugs:check,spotless:check,javadoc:jar,check-natives.py,check-release-gate.py,check-run-scripts.py,check-shared-files.pyand the buildcheck unit tests report nothing.test-cpp-linux-aarch64from Ship CPU backend variants for Linux x86-64 and aarch64 (manylinux_2_28) #485 (both runs for Ship CPU backend variants for Linux x86-64 and aarch64 (manylinux_2_28) #485 were cancelled at the start gate).Related issues / PRs
Follows #482 (b11476). Refs #485 (the CPU variants whose CI jobs run for the first time here).
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdUpgrade llama.cpp from bX to bY).🤖 Generated with Claude Code
https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Generated by Claude Code