Skip to content

acd: uninitialised read of bestPerm in enumerate_iset_combinations #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelwa wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

acd: uninitialised read of bestPerm in enumerate_iset_combinations #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/map/if/acd/ac_decomposition.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,11 @@ class ac_decomposition_impl
for ( uint32_t i = 0; i < num_vars; ++i )
{
pComb[i] = pInvPerm[i] = i;
/* bestPerm is written only when some combination beats the initial
* best_cost. When none does, the loop below still evaluates
* permutations[bestPerm[i]], which reads uninitialised stack and then
* indexes permutations[] with it. Seed the identity permutation. */
bestPerm[i] = i;
}

/* early bail-out conditions */
Expand Down