fix: detect server-initiated closes on idle pooled connections #800
+220
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a server closes an idle connection in the pool, hackney now detects
it via tcp_closed/ssl_closed messages and removes the connection from
the pool, preventing {error, closed} on the next request.
Implementation:
- Enable {active, once} on sockets when connections become idle in pool
- Handle tcp_closed/ssl_closed in connected state to transition to closed
- Pooled connections in closed state terminate with {stop, normal}
- Use peername for health checks (works with active mode)
- Set socket to passive mode before request operations
- Handle HTTP/3 (QUIC) connections where socket is undefined
Closes #544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tcp_closed/ssl_closedvia{active, once}mode when idle in pool{error, closed}on reuseImplementation
{active, once}selectively when connections become idle in pool (not on initial connect)tcp_closed/ssl_closedinconnectedstate → transition toclosedclosedstate terminate with{stop, normal}so pool cleans uppeernamefor health checks (compatible with active mode)Test plan
test_server_close_detectedverifies server-initiated close detectionCloses #544