Skip to content

connect: handle empty lines during handshake #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benoitc wants to merge 2 commits into from
Closed

connect: handle empty lines during handshake #537

benoitc wants to merge 2 commits into from

Conversation

@benoitc
Copy link
Owner

@benoitc benoitc commented Sep 28, 2018

fix #536

This was referenced Oct 3, 2018
Closed
Closed
@benoitc
Copy link
Owner Author

benoitc commented Jan 18, 2026

Closing as already fixed. The issue #536 (empty lines during proxy CONNECT handshake) has been fixed in the current codebase. See check_response/4 in hackney_http_connect.erl which now properly accumulates data until \r\n\r\n is found. Thank you for the contribution!

@benoitc benoitc closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Establishment of SSL over HTTP CONNECT tunnel (sometimes) fails with {error,{tls_alert,"record overflow"}}

2 participants

@benoitc