Conversation
Reject requests whose alignment and allocator headers would overflow size_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The allocator aligns each requested size and adds an internal block header. For values near
SIZE_MAX, these calculations can wrap and make an oversized request appear to be a small allocation.As a result,
js_malloc_rt()can return an undersized block for an unrepresentable request. The same issue affects allocation and reallocation paths, while the default allocator's memory-limit checks also contain arithmetic that can wrap before comparison.Fix
SIZE_MAXallocation, zeroed allocation, and reallocation requests.A failed reallocation continues to preserve the original allocation and its contents.
Testing
make -j8 testmake CONFIG_ASAN=y CONFIG_UBSAN=y -j8 test