feat(ftintitle): hook metadata events, fixing mbsync#6726
Open
treyturner wants to merge 1 commit into
Open
Conversation
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
from
38e0446 to
8839b95
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6726 +/- ##
==========================================
+ Coverage 74.54% 74.62% +0.07%
==========================================
Files 162 162
Lines 20832 20909 +77
Branches 3298 3313 +15
==========================================
+ Hits 15529 15603 +74
+ Misses 4548 4547 -1
- Partials 755 759 +4
🚀 New features to boost your workflow:
|
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
4 times, most recently
from
ff4a62f to
06da57e
Compare
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
from
06da57e to
9e8f19c
Compare
snejus
requested changes
Jun 12, 2026
snejus
left a comment
snejus
left a comment
Member
There was a problem hiding this comment.
Let's split the following into a separate PR:
Define each configuration option as a @cached_property to remove the need to send them through each function. See 34772d2 where I did the same for convert plugin.
This will remove a big chunk of the current PR diff and make it easier to review the functionality that you added.
3 tasks
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
3 times, most recently
from
3719e23 to
ff085e4
Compare
Contributor
Author
|
The cached properties are now in #6732 on which this PR is based. The remaining changes can be seen in the single subsequent commit: |
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
from
ff085e4 to
7bfb1a7
Compare
snejus
added a commit
that referenced
this pull request
Jun 13, 2026
Pre-factor for #6726. Make `ftintitle`'s config `@cached_property` attributes instead of passing them through the call stack. Modeled after similar recent changes in `convert`. ## Changes - Add cached plugin properties for `auto`, `drop`, `format`, `keep_in_artist`, `preserve_album_artist`, and `custom_words`, keeping the existing cached `bracket_keywords` property I forgot I added a while back. - `commands()`, `imported()`, `ft_in_title()`, and `update_metadata()` are cleaned up to read these directly. - Don't read `auto` during plugin init; the import stage remains registered and `imported()` checks `auto` when invoked.
Member
|
Now rebase it on master and I'll review it again :) |
treyturner
force-pushed
the
feat/ftintitle-hook-metadata-events
branch
from
7bfb1a7 to
7b4d06a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #6732.
Summary
This PR integrates
ftintitlewith metadata fetched through beets’ metadata-received events, so commands likembsyncapply already-normalized metadata whenftintitleis enabled.Addresses #1153.
Changes
ftintitlelisteners fortrackinfo_receivedandalbuminfo_receivedwhenftintitle.autois enabled.TrackInfometadata beforembsyncapplies it, avoiding unnecessary re-sync churn.artist_credit, cachedInfoproperties, empty titles, and no-op configurations consistently.ftintitledocs for the expandedautobehavior.To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)