gcm: support numeric sender registrations - #4
Open
iFixRobots wants to merge 2 commits into
Open
Conversation
|
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Numeric FCM sender IDs were registered as WebPush subscriptions, which Google rejects. Their pushes arrive with an app category instead of a subtype, leaving
MessageEvent.AppIDempty.Fix
Use Chromium's extension registration format for numeric senders and read the category when a push has no subtype. Return registration errors explicitly so callers can handle failed requests.
Notes
Verified live registration and unregistration with Google. Captured Google Voice pushes carrying the registration ID in their category.
go build ./...andgo vet ./...pass.Related: #3