Skip to content

Return errors from failed FCM registration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iFixRobots wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return errors from failed FCM registration #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gcm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,15 @@ func RegisterGCM(ctx context.Context, authorizationEntity string, creds GCMCrede
if err != nil {
return nil, errors.Wrap(err, "parse GCM register URL")
}
if errorCode := subscription.Get("Error"); errorCode != "" {
return nil, errors.Errorf("GCM registration failed: %s", errorCode)
} else if res.StatusCode != http.StatusOK {
return nil, errors.Errorf("GCM registration failed with HTTP %d", res.StatusCode)
}
token := subscription.Get("token")
if token == "" {
return nil, errors.New("GCM registration returned an empty token")
}

return &FCMCredentials{
GCM: creds,
Expand Down
Loading