chore(deps-dev): bump vitest, @vitest/coverage-v8 and @vitest/ui from 3.2.7 to 4.1.11 in /services/web-app - #73
Merged
Merged
Conversation
… 3.2.7 to 4.1.11 in /services/web-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's #72 moved
vitestto 4.1.11 and left@vitest/coverage-v8and@vitest/uiat 3.2.7. Both peer-pin the exact vitest version, and vitest 4 dropped vite-node, so the 3.x coverage provider dies inV8CoverageProvider.convertCoveragereadingfetchCacheoff avitenodeobject that no longer exists. That is theTypeError: Cannot read properties of undefined (reading 'fetchCache')in "Frontend · Tests"; vitest says as much right above the crash:Loaded vitest@4.1.11 and @vitest/coverage-v8@3.2.7. Running mixed versions is not supported.What moved.
vitest,@vitest/coverage-v8,@vitest/ui->^4.1.11, lockfile regenerated with pnpm 9.15.9 (what CI installs). Nothing else had to move:vite6.4.3 satisfies vitest 4's^6 || ^7 || ^8peer range,@vitejs/plugin-react-swc4.3.3 andjsdom26.1.0 stay where master has them, and vitest 4.1.11 (expect-type: ^1.3.0) still resolvesexpect-type@1.4.0, so the pnpm patch keeps applying (1.4.0 is upstream's latest and still ships noexports).One config line.
coverage.include: ["src/**/*.{ts,tsx}"]invitest.config.ts. Vitest 4 removedcoverage.all; by default only files imported during the run are counted, which would have lifted the frontend flag on codecov from ~10% to ~58% without a single new test. Theincludepins the denominator back to the whole source tree, which is what the existingexcludelist was written against. There are no.js/.jsxfiles undersrc/, so the set is the same one 3.x reported.What I ran, on Node 22.23.2 (CI's major, via
npx -p node@22; local default is 26) withpnpm@9.15.9, inservices/web-app:pnpm install --frozen-lockfile && pnpm test:coverage:RUN v3.2.7,Test Files 9 passed (9),Tests 93 passed (93),All files 9.96.pnpm installthenpnpm test:coverage:RUN v4.1.11,Test Files 9 passed (9),Tests 93 passed (93), no mixed-version warning,All files 11.77(same file set; v4's AST-based remapping counts lines a bit differently; withoutincludeit printed57.88).pnpm lint: clean.pnpm typecheck: clean.Replaces #72.