fix: accept both cap spellings, and stop one request rewriting the next - #22
Merged
Merged
Conversation
The work landed in #21. Its squash subject lost the Conventional Commit prefix -- my mistake on the merge, not the author's -- so release-please skipped the merge and these fixes would never have reached a release. This commit carries the record. It changes no code: #21 is already on master. * OperationDeadlineConfig spells the field calls_caps while BudgetContext.create takes call_caps, and the model ignored the unknown key, so a configuration written the second way silently carried no caps at all. Both spellings are accepted now through AliasChoices, and serialisation is unchanged. * BudgetContext held the caps dict it was handed rather than a copy. Because the factory passes the settings object's own dict straight through, mutating one request's caps rewrote the application-scoped settings and every later context for that operation. * make install and the contributing guide now sync the extras CI uses, so make test-unit works on a fresh checkout instead of failing at collection.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes. One empty commit restoring a record the merge of #21 lost.
I squash-merged #21 using its pull request title as the subject, and that title was prose rather than a Conventional Commit. release-please parses subjects, found nothing releasable since
deadline-budget-v0.1.2, and opened no release pull request — so the fixes would have sat onmasterindefinitely. My mistake on the merge, not the author's.What #21 actually fixed, now stated in a subject the tooling reads:
OperationDeadlineConfigspells the fieldcalls_capswhileBudgetContext.createtakescall_caps, and the model ignored the unknown key — so a configuration written the second way silently carried no caps at all. Both spellings are accepted now.BudgetContextheld the caps dict it was handed rather than a copy. Since the factory passes the settings object's own dict straight through, mutating one request's caps rewrote the application-scoped settings and every later context for that operation.make installand the contributing guide now sync the extras CI uses, somake test-unitworks on a fresh checkout.The diff is empty by design. Reviewing it means reading #21.