Repository navigation
fix: stop a running command at once when the instance is dropped - #10
Merged
Merged
Conversation
…kit#1) drop_instance used to wait for the instance lock, which a dispatch holds for its whole run. A registry of live process trees now sits outside the lock: the drop asks every tree to stop first, and the step in flight escalates to a kill when what is left of the grace runs out.
sergeym
force-pushed
the
fix/issue-1-immediate-stop
branch
from
October 16, 2026 20:52
3adf964 to
028771f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.
bddkit_drop_instancewaited for the instance lock, which a dispatch holds for its whole run. Live process trees now sit in a registry outside the lock: the drop asks every tree to stop first, the step in flight kills its tree when the remainingstop_grace_secsruns out and fails with "the run was interrupted", and the later reset spends only the grace that is left. No ABI change; behaviour without an interrupt is unchanged.Verified: unit, in-process export test (drop mid-
sleep 30returns within the grace) and e2e against bddkit 0.3.0 all green; clippy clean; Windows target compile-checked only.