Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Upstream draft PR is now open: bcomnes/domstack#320. It provides the canonical TypeScript default layout and --eject --language js|ts --yes support used here. Publish the upstream change and update this generator’s @domstack/static range before releasing. |
There was a problem hiding this comment.
🟡 Changes recommended
Three critical issues remain unresolved, including an incompatible published dependency range and workflow security concerns.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds interactive starter options, framework/Tailwind setup, deployment workflows, DOMStack ejection, dependency management, documentation, and integration tests.
Changes:
- Adds JS/TS, Preact/React, Tailwind, and deployment choices.
- Adds GitHub Pages and Neocities workflow generation.
- Adds manifest-derived dependency ranges, Dependabot configuration, and smoke tests.
Unresolved critical findings:
deployment.ts:103— Pin the third-party action to an audited commit SHA and retain a version comment. (3 votes)deployment.ts:5— Setpersist-credentials: falseon checkout to prevent token exposure. (1 vote)package.json:13— Update the DOMStack dependency to a published release supporting--languageand--yes. (3 votes)
File summaries
| File | Description |
|---|---|
template.ts |
Generates language, framework, and Tailwind starter files. |
template.test.ts |
Tests feature combinations. |
smoke.ts |
Provides packed integration testing. |
README.md |
Documents options, deployment, and setup. |
prompts.ts |
Implements interactive feature selection. |
prompts.test.ts |
Tests prompt behavior and defaults. |
package.json |
Adds starter dependencies and build scripts. |
index.ts |
Orchestrates generation, installation, and ejection. |
index.test.ts |
Tests the generator API. |
eject.test.ts |
Tests package-manager ejection behavior. |
deployment.ts |
Generates deployment workflows. |
deployment.test.ts |
Tests deployment output and configuration. |
dependencies.ts |
Reads dependency ranges from package metadata. |
dependencies.test.ts |
Tests dependency-range resolution. |
defaults.ts |
Restores Tailwind defaults after ejection. |
bin.ts |
Connects CLI parsing, prompts, and project creation. |
.github/dependabot.yml |
Enables dependency range updates. |
Review details
- Files reviewed: 17/17 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const buildSteps = ` - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 |
| runs-on: ubuntu-latest | ||
| steps: | ||
| ${buildSteps} - run: npm run build | ||
| - uses: bcomnes/deploy-to-neocities@v3 |
| "@voxpelli/tsconfig": "^16.1.0", | ||
| "@types/node": "^26.0.0", | ||
| "@types/node": "^26.0.1", | ||
| "@domstack/static": "^12.0.0-beta.5", |
Summary
Validation
Release blocker
This draft depends on the upstream DOMStack feat/typescript-default-eject changes providing --eject --language ts|js --yes.
Publish those changes and update the @domstack/static devDependency range before releasing this generator.
The current range remains ^12.0.0-beta.5; local integration validation used a tarball of the upstream working tree rather than a published release.