fix(deploy): bump deployer to stop logging rendered templates - #500
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The pinned commit matches v0.3.2 and contains the documented template-leak fix.
Review effort: Balanced
Findings: None
What changed in this PR
Updates OpenShift deployment workflows to v0.3.2, preventing rendered templates and secrets from leaking into logs.
Changes:
- Pins deployer and PR cleanup workflows to the verified v0.3.2 commit.
- Removes all remaining references to the vulnerable version.
| File | Description |
|---|---|
.github/workflows/.deploy.yml |
Updates both deployer invocations. |
.github/workflows/pr-close.yml |
Updates the reusable cleanup workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent security fix: bump the OpenShift deployer to a release that no longer logs rendered templates.
Deployer versions before this wrote the fully rendered template (including Secret values) into the job environment, so it was printed in the
env:header of every later step in the job. The template is JSON, which escapes characters such as&,<and>, so GitHub's secret masking did not reliably catch those values. This release keeps the rendered template in a private temp file that is always removed and never prints its contents.Only the pin lines change.
Past workflow run logs may contain secrets. Please review them and rotate any credentials that could have been exposed.