Repository navigation
fix(ci): remove tag fallback in merge flow - #498
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow changes consistently implement the stated single-tag deployment behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the obsolete manual tag override so merge deployments consistently use the resolved image tagged with the triggering commit SHA.
Changes:
- Removes the
workflow_dispatchtag input and conditional gates. - Uses
${{ github.sha }}for test, production, and image promotion.
| File | Description |
|---|---|
.github/workflows/merge.yml |
Standardizes merge-flow image resolution, deployment, and promotion on the commit SHA. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
inputs.tag || github.shafallback frommerge.yml, so every deploy uses one explicit tag.Deploy (TEST), Deploy (prod) and Promote Images now use
${{ github.sha }}. That is the merge-commit tag the Resolve Images job creates from the digest image-tracker resolves.Removes the unused
workflow_dispatchtaginput and the twoif: ${{ !inputs.tag }}step gates. The input predates chore(ci): pin bcgov action suites to v0.8.0 / v0.3.1 and move off standalone actions #497 and has never been used (0 dispatch runs). A manual dispatch now resolves and deploys the dispatched commit the same way a push does.Java
Py