Skip to content

fix(ci): remove tag fallback in merge flow - #498

Merged
DerekRoberts merged 1 commit into
mainfrom
fix/no-tag-fallback
Sep 25, 2026
Merged

DerekRoberts merged 1 commit into
mainfrom
fix/no-tag-fallback

Conversation

@DerekRoberts

@DerekRoberts DerekRoberts commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Removes the inputs.tag || github.sha fallback from merge.yml, so every deploy uses one explicit tag.

  • Deploy (TEST), Deploy (prod) and Promote Images now use ${{ github.sha }}. That is the merge-commit tag the Resolve Images job creates from the digest image-tracker resolves.

  • Removes the unused workflow_dispatch tag input and the two if: ${{ !inputs.tag }} step gates. The input predates chore(ci): pin bcgov action suites to v0.8.0 / v0.3.1 and move off standalone actions #497 and has never been used (0 dispatch runs). A manual dispatch now resolves and deploys the dispatched commit the same way a push does.

  • Java

  • Py

Copilot AI balanced review requested due to automatic review settings September 25, 2026 03:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow changes consistently implement the stated single-tag deployment behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Removes the obsolete manual tag override so merge deployments consistently use the resolved image tagged with the triggering commit SHA.

Changes:

  • Removes the workflow_dispatch tag input and conditional gates.
  • Uses ${{ github.sha }} for test, production, and image promotion.
File Description
.github/​workflows/​merge.yml Standardizes merge-flow image resolution, deployment, and promotion on the commit SHA.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@DerekRoberts DerekRoberts self-assigned this Sep 25, 2026
@DerekRoberts
DerekRoberts merged commit 76d8491 into main Sep 25, 2026
21 checks passed
@DerekRoberts
DerekRoberts deleted the fix/no-tag-fallback branch September 25, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants