test: verify shell pane toggle (backslash key) works correctly #317
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the backslash (\) key binding for toggling the shell pane is:
- Properly defined with the correct key
- Has correct help text ("toggle shell")
- State accessor IsShellPaneHidden() returns correct values
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add the backslash (\) shortcut to the help bar at the bottom of the detail view. The shortcut shows "hide shell" when the shell pane is visible and "show shell" when it's hidden. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The \ shortcut only works in detail view where there's a shell pane. Remove it from the kanban FullHelp() - it's now only shown in the detail view help bar where it's actually usable. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bborn
force-pushed
the
task/786-check-that-cmd-to-toggle-shell-pane-actu
branch
from
23c6663 to
474e6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
\) is correctly configuredIsShellPaneHidden()state accessor works properlyTest plan
go test ./internal/ui/... -v -run "ShellPane|ToggleShellPane"- all tests passgo test ./...- all existing tests still pass\to toggle shell pane visibilityImplementation review
The shell pane toggle feature (added in commit e38d4ad) was reviewed and works correctly:
\is bound toToggleShellPaneinapp.go:204-207m.detailView.ToggleShellPane()inapp.go:1662-1665detail.go:1378-1545handles hide/show with proper state managementSettingShellPaneHidden)detail.go:282-284app.go:99🤖 Generated with Claude Code