opt into goUpdate.autoUpdate - #91
Merged
Merged
Conversation
There was a problem hiding this comment.
The review is complete. The diff is a 6-line YAML configuration change — no source code, no rule-relevant files, no violations.
PR Review: chore/goupdate-optin → master
Files changed: .maintainer.yaml (+6 lines)
Must Fix (Critical)
None.
Should Fix (Important)
None.
Nice to Have (Optional)
None.
Selector Mode Traceability
- Candidates: 0 rules matched by Step 4b-i glob filter (no Go/Python/Node source, no CHANGELOG, no go.mod, no Makefile, no k8s YAML, no agent/command/skill docs)
- Applicable: 0
- Skipped: N/A — diff contains no rule-relevant files; Step 4b-i produced an empty candidate set
Step 4 Status
Step 4 skipped: no file in the diff matches any rule trigger glob. The mechanical funnel confirmed 0 findings across 74 YAML scans.
Step 3b Status
precommit skipped (selector mode) — CI covers lint+test.
Notes
The diff is a single config-file edit adding goUpdate.autoUpdate: true under a new goUpdate: section in .maintainer.yaml. The YAML structure is well-formed and the PR description correctly notes the second gating requirement (repo must also be in the watcher's REPO_ALLOWLIST). No source code is touched.
{
"verdict": "approve",
"summary": "Trivial config-only change: adding goUpdate.autoUpdate: true to .maintainer.yaml. No source code modified, no rule-relevant files touched, mechanical funnel clean with 0 findings across 74 YAML scans.",
"comments": [],
"concerns_addressed": [
"correctness: YAML indentation and structure verified correct for nested goUpdate.autoUpdate key",
"security: goUpdate.autoUpdate enables go-watcher task filing; PR description confirms repo is already in REPO_ALLOWLIST as the second gating control"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the two gates
github-update-go-watcherrequires before filing a Go-version update task for this repo.REPO_ALLOWLIST(operator-controlled scope), and.maintainer.yamlsetsgoUpdate.autoUpdate: true.Absent file, absent section, and absent key all read as false — a trust gate, so a repo opts in deliberately and never by accident. Config-only; no CHANGELOG entry, so this does not trigger a release.
Safe to merge: every
.maintainer.yamlconsumer parses leniently except github-releaser-agent, which was fixed in v0.4.2 (maintainer v0.49.0) and is deployed to dev and prod. Before that fix this key wedged releases withfield goUpdate not found.