Skip to content

opt into goUpdate.autoUpdate - #91

Merged
bborbe merged 1 commit into
masterfrom
chore/goupdate-optin
Aug 16, 2026
Merged

opt into goUpdate.autoUpdate#91
bborbe merged 1 commit into
masterfrom
chore/goupdate-optin

Conversation

@bborbe

@bborbe bborbe commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Second of the two gates github-update-go-watcher requires before filing a Go-version update task for this repo.

  1. the repo is in the watcher's REPO_ALLOWLIST (operator-controlled scope), and
  2. this repo's own .maintainer.yaml sets goUpdate.autoUpdate: true.

Absent file, absent section, and absent key all read as false — a trust gate, so a repo opts in deliberately and never by accident. Config-only; no CHANGELOG entry, so this does not trigger a release.

Safe to merge: every .maintainer.yaml consumer parses leniently except github-releaser-agent, which was fixed in v0.4.2 (maintainer v0.49.0) and is deployed to dev and prod. Before that fix this key wedged releases with field goUpdate not found.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review is complete. The diff is a 6-line YAML configuration change — no source code, no rule-relevant files, no violations.


PR Review: chore/goupdate-optinmaster

Files changed: .maintainer.yaml (+6 lines)

Must Fix (Critical)

None.

Should Fix (Important)

None.

Nice to Have (Optional)

None.

Selector Mode Traceability

  • Candidates: 0 rules matched by Step 4b-i glob filter (no Go/Python/Node source, no CHANGELOG, no go.mod, no Makefile, no k8s YAML, no agent/command/skill docs)
  • Applicable: 0
  • Skipped: N/A — diff contains no rule-relevant files; Step 4b-i produced an empty candidate set

Step 4 Status

Step 4 skipped: no file in the diff matches any rule trigger glob. The mechanical funnel confirmed 0 findings across 74 YAML scans.

Step 3b Status

precommit skipped (selector mode) — CI covers lint+test.

Notes

The diff is a single config-file edit adding goUpdate.autoUpdate: true under a new goUpdate: section in .maintainer.yaml. The YAML structure is well-formed and the PR description correctly notes the second gating requirement (repo must also be in the watcher's REPO_ALLOWLIST). No source code is touched.


{
  "verdict": "approve",
  "summary": "Trivial config-only change: adding goUpdate.autoUpdate: true to .maintainer.yaml. No source code modified, no rule-relevant files touched, mechanical funnel clean with 0 findings across 74 YAML scans.",
  "comments": [],
  "concerns_addressed": [
    "correctness: YAML indentation and structure verified correct for nested goUpdate.autoUpdate key",
    "security: goUpdate.autoUpdate enables go-watcher task filing; PR description confirms repo is already in REPO_ALLOWLIST as the second gating control"
  ]
}

@bborbe
bborbe merged commit 7ac3676 into master Aug 16, 2026
1 check passed
@bborbe
bborbe deleted the chore/goupdate-optin branch August 16, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant