move Unreleased above v0.111.0 in CHANGELOG - #86
Merged
Conversation
PR #85 anchored its '## Unreleased' section above '## v0.110.0'. v0.111.0 was released from a commit in between and landed above it, so the merge — clean, no conflict — left Unreleased stranded between two released sections: ## v0.111.0 ## Unreleased <- here ## v0.110.0 The releaser reads the newest section; with Unreleased below a released one it either renames a section in the wrong position or sees nothing to ship. A release-check trigger after #85 merged produced no new tag, which is consistent with the latter. Pure reordering — the bullet text is unchanged.
There was a problem hiding this comment.
The diff is a pure CHANGELOG.md reordering — ## Unreleased moved above ## v0.111.0. Per the changelog guide, ## Unreleased must go directly above the highest ## vX.Y.Z (newest version first). The post-change CHANGELOG is correctly ordered.
No code files changed. Step 4 is not applicable (no rule-relevant source files). The change is clean.
{
"verdict": "approve",
"summary": "CHANGELOG-only reorder placing `## Unreleased` above `## v0.111.0` — correct per changelog convention. No code changes.",
"comments": [],
"concerns_addressed": []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#85 anchored its
## Unreleasedsection above## v0.110.0. v0.111.0 was released from a commit in between, and landed above it. Both merges were clean — nothing conflicted — leaving## Unreleasedstranded between two released sections:The releaser reads the newest section. With
## Unreleasedsitting below a released one, it either renames a section in the wrong position or concludes there is nothing to ship. A release-check trigger fired after #85 merged produced no new tag, which is consistent with the latter — so #85's fix is on master but cannot currently be released.Why the usual guard missed it
The changelog-fold check (
git diff origin/master -- CHANGELOG.md | grep -E '^[-+]## ') passes at push time, because on the branch## Unreleasedgenuinely is the top section. It only becomes wrong when someone else's release lands above it — after the check has already run and passed.Worth knowing: anchoring a new
## Unreleasedrelative to a specific released version is what creates the exposure. Anchoring it to the top of the section list would not have.Change
Pure reordering —
## Unreleasedmoved above## v0.111.0. Bullet text unchanged (git difftouches 4 lines, 2 of them the same bullet moving).Verification
After merge, a release check should cut the version carrying #85's Phase 5.5 fix.