Skip to content

update go module dependencies - #11

Merged
bborbe merged 2 commits into
masterfrom
fix/update-go-a178b3f
Aug 17, 2026
Merged

update go module dependencies#11
bborbe merged 2 commits into
masterfrom
fix/update-go-a178b3f

Conversation

@ben-s-go-updater

Copy link
Copy Markdown

Automated Go toolchain + dependency update.

  • go directive: 1.26.5 -> 1.26.6
  • dependencies updated: 11
  • vulnerabilities fixed: GO-2026-6179, GO-2026-6180
  • gate green: precommit, check (exit 0)
  • notes: Go 1.26.5→1.26.6; updated bborbe/* deps (collection, kv, log, math, parse, run, time) and golang.org/x/* deps (mod, net, tools); vulns GO-2026-6179 and GO-2026-6180 fixed via golang.org/x/mod@v0.40.0; all gate targets green

CHANGELOG entry stays under ## Unreleased — the release agent versions and tags on merge.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have enough to perform the selector-mode adjudication. Let me analyze the diff and findings:

Step 4c-sel CLASSIFY:

Changed files: CHANGELOG.md, go.mod, go.sum

Rule Decision Reason
changelog/conventional-prefix-required Applicable CHANGELOG.md changed; entry lacks prefix
go-mod-dependency-fix/tidy-after-get-update Skipped go mod tidy was run (both go.mod + go.sum updated together)
changelog/unreleased-entry-required Skipped Entry exists — not violated
adr/required-for-irreversible-architecture-decisions Skipped Toolchain version bump ≠ irreversible architecture decision

Step 4d-sel ADJUDICATE:

  • changelog/conventional-prefix-required: The entry update Go to 1.26.6 and update dependencies starts with bare update instead of chore:. Per the changelog guide, dependency updates should use chore: and include version numbers. Severity: Should Fix (Important).

The go mod tidy was properly run (both go.mod and go.sum updated together with consistent entries). No other violations.


PR Review: update go module dependencies

Must Fix (Critical): None.

Should Fix (Important):

  • CHANGELOG.md:10 — changelog entry uses bare update instead of chore: prefix. Per changelog/conventional-prefix-required, dependency updates must use chore: and include version numbers. Should be chore: Update Go to 1.26.6 and update dependencies. (rule: changelog/conventional-prefix-required)

Nice to Have (Optional): None.


Notes:

  • golang.org/x/mod updated v0.39.0 → v0.40.0 (fixes GO-2026-6179 and GO-2026-6180 — correct)
  • golang.org/x/net updated v0.57.0 → v0.58.0
  • Go toolchain updated 1.26.5 → 1.26.6 (patch, non-breaking)
  • All bborbe/* dependencies updated to latest patch versions
  • go mod tidy was run (both go.mod and go.sum updated together) — go-mod-dependency-fix/tidy-after-get-update satisfied
  • precommit skipped (selector mode) — CI covers lint+test

Traceability:

  • Candidates: 4 judgment rules matched by Step 4b-i glob filter
  • Applicable: 1 rule selected by Step 4c-sel
  • Skipped: go-mod-dependency-fix/tidy-after-get-update → tidy was run; adr/required-for-irreversible-architecture-decisions → toolchain patch bump not architectural; changelog/unreleased-entry-required → entry present; 1 more skipped

{
  "verdict": "approve",
  "summary": "Dependency update is clean — golang.org/x/mod and golang.org/x/net security patches applied, go toolchain bumped to 1.26.6, all bborbe/* deps updated to latest. The only finding is the CHANGELOG entry missing the `chore:` conventional prefix (Should Fix level). go mod tidy was run correctly.",
  "comments": [
    {
      "file": "CHANGELOG.md",
      "line": 10,
      "severity": "major",
      "message": "changelog: entry uses bare 'update' instead of 'chore:' prefix — use 'chore: Update Go to 1.26.6 and update dependencies' per changelog/conventional-prefix-required"
    }
  ],
  "concerns_addressed": [
    "security: vulnerabilities GO-2026-6179 and GO-2026-6180 fixed via golang.org/x/mod@v0.40.0",
    "correctness: Go toolchain updated 1.26.5 -> 1.26.6; patch release, no breaking changes",
    "correctness: 11 dependencies updated; go mod tidy run correctly (both go.mod and go.sum updated together)",
    "tests: precommit skipped in selector mode — CI covers lint+test"
  ]
}

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
@ben-s-pull-request-reviewer
ben-s-pull-request-reviewer Bot dismissed their stale review August 17, 2026 09:40

superseded by new automated review

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 4c-sel CLASSIFY

The diff changes only CHANGELOG.md, go.mod, and go.sum. Applying the Step 4b-i glob filter over the rules index:

Candidates (matching triggers):

Rule Owner applies_when
changelog/conventional-prefix-required agent-auditor CHANGELOG.md
go-mod-dependency-fix/tidy-after-get-update go-quality-assistant go.mod, go.sum
go-mod-dependency-fix/exclude-over-cross-repo-replace go-quality-assistant go.mod

All other rules have triggers that don't match the changed files (no .go files, no agents/**, no commands/**, no skills/**, no main.go, etc.).

Step 4d-sel ADJUDICATE

Mechanical findings: Step 4a returned {stats: {findings_count: 0}} — zero findings. No violations to adjudicate.

Rule-level scan:

  • changelog/conventional-prefix-required: The ## Unreleased bullet is - chore: bump \github.com/bborbe/run` v1.9.34 -> v1.9.35. chore:` is a valid conventional prefix. No violation.

  • go-mod-dependency-fix/tidy-after-get-update: The diff shows github.com/bborbe/run version bumped from v1.9.34 to v1.9.35 in both go.mod and go.sum. go.sum diff shows the old hash removed and new hash added — this is exactly the signature of go mod tidy. Additionally, the replace and exclude directives were changed from parenthesized block form to single-line form (cosmetic), and bazelbuild/buildtools was moved from require to a local replace (downstream effect of the tidy). No orphaned hashes. No violation.

  • go-mod-dependency-fix/exclude-over-cross-repo-replace: The replace directive is github.com/bazelbuild/buildtools => github.com/bazelbuild/buildtools v0.0.0-20250826111327-4006b543a694 — same repo on both sides (not cross-repo). The exclude directive for cloud.google.com/go v0.26.0 is a legitimate version exclusion, not a cross-repo replace. No violation.

Citation validation: Not needed — no findings were emitted from adjudication.


Step 3: LICENSE present. Precommit skipped (selector mode).

Selector mode traceability:

  • Candidates: 3 rules matched by Step 4b-i glob filter
  • Applicable: 3 rules selected by Step 4c-sel
  • Skipped: none

Must Fix (Critical)

None.

Should Fix (Important)

None.

Nice to Have (Optional)

None.

Notes:

  • The replace and exclude directive reformatting (block → single line) is cosmetic and does not affect module resolution behavior.
  • The dependency update (bborbe/run v1.9.34 → v1.9.35) is a patch bump — no semver risk.
  • CI will verify the build and tests with the new dependencies.

{
  "verdict": "approve",
  "summary": "Dependency update PR touching only go.mod/go.sum/CHANGELOG.md. The go mod tidy signature is present in go.sum, conventional changelog prefix is correct, replace/exclude directives are properly scoped, and the mechanical funnel found zero violations. Approve.",
  "comments": [],
  "concerns_addressed": [
    "security: no CVE data provided — security posture of v1.9.35 vs v1.9.34 unknown, but no mechanical finding was raised by the security rules",
    "correctness: no API breaking change at patch version bump — no go.mod API signature issues",
    "tests: go.sum tidy signature present, CI will verify build and test pass"
  ]
}

@bborbe
bborbe merged commit 6c27fb5 into master Aug 17, 2026
3 checks passed
@bborbe
bborbe deleted the fix/update-go-a178b3f branch August 17, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant