chore: rebuild to pick up coding v0.42.3 licensing fix - #12
Merged
Conversation
The coding plugin is baked into this image at build time and frozen for the life of the tag, so a plugin fix only reaches the reviewer bot via a new agent image. coding v0.42.3 gates the two go-licensing MUST rules on real repo visibility; without this rebuild the bot keeps blocking every private repo that has no LICENSE, which is 69 of 73 in Seibert-Data.
There was a problem hiding this comment.
Based on my analysis:
Changed files: CHANGELOG.md only (4 lines added)
Step 4b-i candidates (rules with triggers matching CHANGELOG.md):
changelog/conventional-prefix-required(judgment, owner: agent-auditor)changelog/unreleased-entry-required(script, owner: agent-auditor)changelog/preamble-frozen(script, owner: agent-auditor)
Step 4c-sel CLASSIFY:
changelog/conventional-prefix-required→ applicable — diff adds achore:prefixed bullet under## Unreleasedchangelog/unreleased-entry-required→ applicable — diff adds a- chore:bullet under## Unreleased; condition satisfiedchangelog/preamble-frozen→ skipped — diff adds content after the preamble block, not above# Changelogor inside the preamble
Step 4d-sel ADJUDICATE:
The applicable rules both concern CHANGELOG structure. The diff:
- Adds
## Unreleasedsection (correctly placed after preamble) - Adds a
chore:prefixed bullet (correct format per conventional commits)
No violations found. The mechanical funnel confirmed 0 findings across 74 rule files.
Step 4 early-exit (selector clean — no adjudication needed): All applicable rules passed, 0 mechanical findings.
{
"verdict": "approve",
"summary": "PR adds a correctly-formatted `chore:` changelog bullet under `## Unreleased`, with no preamble violations. Mechanical funnel (74 YAMLs) returned zero findings. All triggered changelog rules pass.",
"comments": [],
"concerns_addressed": []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-only PR — the rebuild is the change.
Why
bborbe/codingv0.42.3 fixes the twogo-licensingMUST rules to gate on real repo visibility (bborbe/coding#105). Before that fixcheck_license_file_requiredwas a bare[ ! -f LICENSE ]— its message claimed "Public Go projects must…" but nothing checked whether the repo was public, so the guide's private-repo exemption was documented and never implemented.This image bakes the plugin at build time and freezes it for the life of the tag (
Dockerfile:26-28;.chart-maintainerspec054-parallel-agent-reviews-bake-plugin-drop-pvc.md:45— "plugin updates now ship via image rebuild + redeploy"). So the reviewer bot cannot pick up a plugin fix any other way: a new tag → new image → redeploy is the delivery mechanism.Impact if not shipped
The bot keeps emitting
go-licensing/license-file-requiredon private repos. 69 of 73 non-archivedSeibert-Datarepos carry no LICENSE by design, so this MUST-tier finding fires on essentially every PR in the org — Seibert-Data/agent#7 had to be admin-merged to get past it, which is exactly the one-person bottleneck theoverride-reviewwork exists to remove.After merge
Release cuts the tag, then
make build uploadpublishes the image (CI does not push it), thensm-octopus/agent/maintainervalues bump dev → staging → prod, each separately approved.