Skip to content

chore: rebuild to pick up coding v0.42.3 licensing fix - #12

Merged
bborbe merged 1 commit into
masterfrom
chore/rebuild-coding-v0.42.3
Aug 13, 2026
Merged

chore: rebuild to pick up coding v0.42.3 licensing fix#12
bborbe merged 1 commit into
masterfrom
chore/rebuild-coding-v0.42.3

Conversation

@bborbe

@bborbe bborbe commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Changelog-only PR — the rebuild is the change.

Why

bborbe/coding v0.42.3 fixes the two go-licensing MUST rules to gate on real repo visibility (bborbe/coding#105). Before that fix check_license_file_required was a bare [ ! -f LICENSE ] — its message claimed "Public Go projects must…" but nothing checked whether the repo was public, so the guide's private-repo exemption was documented and never implemented.

This image bakes the plugin at build time and freezes it for the life of the tag (Dockerfile:26-28; .chart-maintainer spec 054-parallel-agent-reviews-bake-plugin-drop-pvc.md:45"plugin updates now ship via image rebuild + redeploy"). So the reviewer bot cannot pick up a plugin fix any other way: a new tag → new image → redeploy is the delivery mechanism.

Impact if not shipped

The bot keeps emitting go-licensing/license-file-required on private repos. 69 of 73 non-archived Seibert-Data repos carry no LICENSE by design, so this MUST-tier finding fires on essentially every PR in the org — Seibert-Data/agent#7 had to be admin-merged to get past it, which is exactly the one-person bottleneck the override-review work exists to remove.

After merge

Release cuts the tag, then make build upload publishes the image (CI does not push it), then sm-octopus/agent/maintainer values bump dev → staging → prod, each separately approved.

The coding plugin is baked into this image at build time and frozen for
the life of the tag, so a plugin fix only reaches the reviewer bot via a
new agent image. coding v0.42.3 gates the two go-licensing MUST rules on
real repo visibility; without this rebuild the bot keeps blocking every
private repo that has no LICENSE, which is 69 of 73 in Seibert-Data.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my analysis:

Changed files: CHANGELOG.md only (4 lines added)

Step 4b-i candidates (rules with triggers matching CHANGELOG.md):

  • changelog/conventional-prefix-required (judgment, owner: agent-auditor)
  • changelog/unreleased-entry-required (script, owner: agent-auditor)
  • changelog/preamble-frozen (script, owner: agent-auditor)

Step 4c-sel CLASSIFY:

  • changelog/conventional-prefix-requiredapplicable — diff adds a chore: prefixed bullet under ## Unreleased
  • changelog/unreleased-entry-requiredapplicable — diff adds a - chore: bullet under ## Unreleased; condition satisfied
  • changelog/preamble-frozenskipped — diff adds content after the preamble block, not above # Changelog or inside the preamble

Step 4d-sel ADJUDICATE:
The applicable rules both concern CHANGELOG structure. The diff:

  1. Adds ## Unreleased section (correctly placed after preamble)
  2. Adds a chore: prefixed bullet (correct format per conventional commits)

No violations found. The mechanical funnel confirmed 0 findings across 74 rule files.

Step 4 early-exit (selector clean — no adjudication needed): All applicable rules passed, 0 mechanical findings.


{
  "verdict": "approve",
  "summary": "PR adds a correctly-formatted `chore:` changelog bullet under `## Unreleased`, with no preamble violations. Mechanical funnel (74 YAMLs) returned zero findings. All triggered changelog rules pass.",
  "comments": [],
  "concerns_addressed": []
}

@bborbe
bborbe merged commit 7a32364 into master Aug 13, 2026
1 check passed
@bborbe
bborbe deleted the chore/rebuild-coding-v0.42.3 branch August 13, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant