WS-NA: Temporal Migration (PR 1: Freeze current behavior with characterization tests)#14099
Draft
Isabella-Mitchell wants to merge 1 commit into
Draft
WS-NA: Temporal Migration (PR 1: Freeze current behavior with characterization tests)#14099Isabella-Mitchell wants to merge 1 commit into
Isabella-Mitchell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-NA - 10% time. See plan
Summary
Increases test coverage in preparation for moment -> JS migration work
Code changes
What I added
Deterministic relative-time and DST edge coverage in index.test.js
-- 28 March 2021, 00:30 GMT
-- 28 March 2021, 02:30 BST
-- 31 October 2021, 01:30 BST
-- 31 October 2021, 01:30 GMT
-- 59m59s -> 59 minutes ago
-- 60m -> an hour ago
-- 23h59m59s -> 23 hours ago
-- 24h -> a day ago
-- 29d23h59m59s -> 29 days ago
-- 30d -> a month ago
-- 11 months -> 11 months ago
-- 12 months -> a year ago
Test-only helper for deterministic timestamp formatting in testUtils.js
DST characterization cases in timeFormat.test.js
Testing
Useful Links