Give todos and multi-occur the same group entry point as the rest - #2182
Open
bbatsov wants to merge 2 commits into
Open
Give todos and multi-occur the same group entry point as the rest#2182bbatsov wants to merge 2 commits into
bbatsov wants to merge 2 commits into
Conversation
The sibling commands are meant to be thin wrappers over a generic that takes any list of projects, which is what lets you write the same command for a group of your own. That held for find-file, search and switch-to-buffer; todos reached the generic through a private `projectile--todos', and multi-occur had none at all. So `projectile-todos-in-projects' is the old private function under a public name, and `projectile-multi-occur-in-projects' is lifted out of the sibling command, which now reads like its three neighbours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sibling commands are meant to be thin wrappers over a generic that takes any list of projects, which is what lets you write the same command for a group of your own. That held for find-file, search and switch-to-buffer, but todos reached the generic through a private
projectile--todosand multi-occur had none at all, so the documented two-line wrapper only worked for three of the five.projectile-todos-in-projectsis the old private function under a public name;projectile-multi-occur-in-projectsis lifted out of the sibling command.