Let every shell backend open in another window - #2180
Merged
Conversation
Only vterm, eat and ghostel had an `-other-window' command. The four built-ins took the OTHER-WINDOW argument and ignored it, so there was nothing to build a variant on - meaning the three third-party terminals were better served than the shells that ship with Emacs. `term' just needed the branch on its final `switch-to-buffer', the same shape `vterm' already uses. `shell', `eshell' and `ielm' display their own buffer and have no `-other-window' flavour to call, so they go through `display-buffer-overriding-action', which outranks the action they pass. `projectile-run' gets a variant too, since it dispatches to whichever backend you configured and all of them now honour the flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only vterm, eat and ghostel had an
-other-windowcommand, so the three third-party terminals were better served than the shells that ship with Emacs. The four built-in runners took theOTHER-WINDOWargument and ignored it, so there was nothing to build a variant on.termjust needed the branch on its finalswitch-to-buffer.shell,eshellandielmdisplay their own buffer and have no-other-windowflavour to call, so they go throughdisplay-buffer-overriding-action, which outranks the action they pass.projectile-rungets a variant too, bound tos-p x 4 r.