Save sessions automatically by default - #2179
Merged
Merged
Conversation
`projectile-session-restore-on-switch' has always been on, and it reads what autosave writes. With autosave off by default, turning on `projectile-session-mode' gave you a mode that restores layouts it never records: nothing came back until you ran `projectile-session-save' by hand, and most people would reasonably conclude the restore was broken. Enabling the mode is already an explicit opt-in to session management, so have it manage sessions. Restoring at startup stays opt-in, since that rebuilds the world at launch rather than when you ask for a project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projectile-session-restore-on-switchhas always been on, and it reads what autosave writes. With autosave defaulting to nil, enablingprojectile-session-modegave you a mode that restores layouts it never records, so nothing came back until you ranprojectile-session-saveby hand.Enabling the mode is already an opt-in to session management, so let it manage sessions. Restoring at startup stays off by default, since that rebuilds everything at launch rather than when you ask for a project.