rust_analyzer: fix target exclusions in gen_rust_project#4065
Draft
ptsteadman wants to merge 1 commit into
Draft
rust_analyzer: fix target exclusions in gen_rust_project#4065ptsteadman wants to merge 1 commit into
ptsteadman wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bf0e5b8 to
ef10a69
Compare
Signed-off-by: Patrick Steadman <ptsteadman@gmail.com>
ef10a69 to
1a5097d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_rust_projectdid not support target exclusion patterns (e.g.-//util/process_wrapper/...). Two bugs:lib.rs:bazel buildreceived exclusion patterns before the end-of-options marker--, so Bazel rejected them as unknown flags.aquery.rs: thedeps()expression was constructed by joining all targets with+(e.g.deps(//util/...+-//util/process_wrapper/...)), which is invalid aquery syntax. Exclusions need to use-instead.Before (main), fails at
bazel build:After (this branch), full round-trip succeeds: