Fix incorrect exec transition for cargo_build_script#4040
Conversation
5a7b1ad to
f0efda9
Compare
|
We've found a regression while testing this change internally. To reproduce, patch repro.patch into a clean working copy and run If I understand correctly, the main problem is that the |
|
@slackito can you open a pull-request with the repro so I can see the failure? |
Relying on an exec configuration through targets consumed in
targetleads to the potential forcfg = "exec"to be evaluated differently in the transitive target (in this case,cargo_build_script_runfiles.script) and the consumer (cargo_build_script.data_runfiles). This change moves the script directly back tocargo_build_scriptincfg = "exec"and separately uses acfg = "target"intermediate rule to implement runfiles (solving for bazelbuild/bazel#15486).closes #3201 #3893