Refactor all the input processing code.#756
Merged
aiuto merged 10 commits intobazelbuild:mainfrom Nov 6, 2023
Merged
Conversation
- Create a MappingContext to hold behaviors and defaults - Change calls - from `process_x(ctx, content_map, ..., default_x, default_y, ...)` - to `process_x(mapping_context, ...) 1. This brings the code more in line with the new preferred rule writing style. 1. A major motivation for the change is adding include_runfiles to pkg_tar, where we want to sometimes have add_label_list do the runfiles inclusion for us, and other times we want to revert to legacy behavior. If we always passed it in `ctx`, that would not be possible.
alexeagle
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_x(ctx, content_map, file_deps, <important args>, default_x=None, default_y, ...)process_x(mapping_context, <important args>)ctx, that would not be possible.Other considerations.
xattrsupport #707 first. The whole attribute scheme is not really sufficient.