Add stamping to .deb package version and description#708
Open
bozaro wants to merge 1 commit intobazelbuild:mainfrom
Open
Add stamping to .deb package version and description#708bozaro wants to merge 1 commit intobazelbuild:mainfrom
bozaro wants to merge 1 commit intobazelbuild:mainfrom
Conversation
bozaro
requested review from
aiuto,
dannysullivan,
jylinv0 and
nacl
as code owners
aiuto
reviewed
Jun 5, 2023
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
What is the actual use case you have here. It does not seem to be time stamping, as the others do. There seems to be some general mechanism you are building to pull things from the info files to the build.
If that is the case, there has to be a documentation update about how to use that feature and the pitfalls of it.
| fail("Neither description_file nor description attribute was specified") | ||
|
|
||
| # Files for stamping variables | ||
| if ctx.attr.private_stamp_detect: |
Collaborator
There was a problem hiding this comment.
This should follow the logic of what the others do. Where there is a stamp parameter which can be 1, 0, or -1, and we only use the stamp dectect if -1.
| if ctx.attr.private_stamp_detect: | ||
| args += ["--stamp=@" + ctx.version_file.path] | ||
| args += ["--stamp=@" + ctx.info_file.path] | ||
| files += [ctx.version_file, ctx.info_file] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow use stamping variables inside deb description.